-
Notifications
You must be signed in to change notification settings - Fork 238
feat(sol): add CastExpr
to solidity
#751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
iajoiner
wants to merge
1
commit into
main
Choose a base branch
from
feat/cast-expr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ca12a17
to
a4e8bfe
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #751 +/- ##
=======================================
Coverage 96.08% 96.09%
=======================================
Files 331 331
Lines 58897 58987 +90
=======================================
+ Hits 56593 56682 +89
- Misses 2304 2305 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a4527b0
to
55f1649
Compare
iajoiner
commented
Apr 16, 2025
29969c1
to
754f10e
Compare
7fa3b60
to
14e6e8b
Compare
2860429
to
995f531
Compare
ceda719
to
086c904
Compare
086c904
to
2e0524f
Compare
auto-merge was automatically disabled
April 18, 2025 22:12
Pull request was converted to draft
auto-merge was automatically disabled
April 22, 2025 17:28
Pull request was converted to draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.
Please go through the following checklist
!
is used if and only if at least one breaking change has been introduced.source scripts/run_ci_checks.sh
.source scripts/check_commits.sh
, and the commit history is certified to follow clean commit guidelines as described here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/COMMIT_GUIDELINES.mdmain
have been incorporated to this PR by simple rebase if possible, if not, then conflicts are resolved appropriately.Rationale for this change
We need to allow casting in the Solidity verifier.
What changes are included in this PR?
See title.
Are these changes tested?
Yes.