Skip to content

feat(sol): add CastExpr to solidity #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat(sol): add CastExpr to solidity #751

wants to merge 1 commit into from

Conversation

iajoiner
Copy link
Contributor

@iajoiner iajoiner commented Apr 15, 2025

Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.

Please go through the following checklist

Rationale for this change

We need to allow casting in the Solidity verifier.

What changes are included in this PR?

See title.

Are these changes tested?

Yes.

@iajoiner iajoiner force-pushed the feat/cast-expr branch 3 times, most recently from ca12a17 to a4e8bfe Compare April 15, 2025 18:30
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

Attention: Patch coverage is 98.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.09%. Comparing base (a8e21f9) to head (2e0524f).

Files with missing lines Patch % Lines
...rates/proof-of-sql/src/sql/evm_proof_plan/exprs.rs 98.80% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #751   +/-   ##
=======================================
  Coverage   96.08%   96.09%           
=======================================
  Files         331      331           
  Lines       58897    58987   +90     
=======================================
+ Hits        56593    56682   +89     
- Misses       2304     2305    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@iajoiner iajoiner force-pushed the feat/cast-expr branch 4 times, most recently from a4527b0 to 55f1649 Compare April 16, 2025 13:43
@iajoiner iajoiner requested a review from JayWhite2357 April 16, 2025 13:43
@iajoiner iajoiner marked this pull request as ready for review April 16, 2025 13:43
@iajoiner iajoiner force-pushed the feat/cast-expr branch 3 times, most recently from 29969c1 to 754f10e Compare April 16, 2025 18:27
@iajoiner iajoiner enabled auto-merge April 16, 2025 18:27
@iajoiner iajoiner force-pushed the feat/cast-expr branch 2 times, most recently from 7fa3b60 to 14e6e8b Compare April 16, 2025 18:53
@iajoiner iajoiner force-pushed the feat/cast-expr branch 4 times, most recently from 2860429 to 995f531 Compare April 17, 2025 13:39
@iajoiner iajoiner requested a review from JayWhite2357 April 17, 2025 14:11
@iajoiner iajoiner force-pushed the feat/cast-expr branch 6 times, most recently from ceda719 to 086c904 Compare April 17, 2025 20:08
@iajoiner iajoiner marked this pull request as draft April 18, 2025 22:12
auto-merge was automatically disabled April 18, 2025 22:12

Pull request was converted to draft

@iajoiner iajoiner removed the request for review from JayWhite2357 April 18, 2025 22:12
@iajoiner iajoiner marked this pull request as ready for review April 20, 2025 06:13
@iajoiner iajoiner enabled auto-merge April 20, 2025 06:13
@JayWhite2357 JayWhite2357 marked this pull request as draft April 22, 2025 17:28
auto-merge was automatically disabled April 22, 2025 17:28

Pull request was converted to draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants