fix(ci): let npm-release be dispatched for a tag - #10
Merged
Conversation
Promoting v1.2.6 out of prerelease fired no workflow run, so the npm publish never happened while the crates one did. The release event is not a reliable trigger, and npm-release had no other way in — the only recovery was editing the release again and hoping. Adds workflow_dispatch with a tag input. Publishing is already idempotent, so a re-dispatch of an published version is a no-op rather than a failure. The release id is now looked up from the tag instead of read off github.event.release.id, which is empty on a dispatch. One code path serves both triggers rather than a second one that only gets exercised in an emergency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promoting v1.2.6 out of prerelease fired no workflow run at all.
crates-release.ymlcould be recovered because it has aworkflow_dispatch;npm-release.ymldoesn't, so the npm publish simply didn't happen and the only recovery was to edit the release again and hope the event fired that time.Fix
workflow_dispatchwith ataginput, matchingcrates-release.yml.github.event.release.id, which is empty on a dispatch. One code path serves both triggers, instead of a second path that only ever gets exercised during an emergency.Context
deckfile 1.2.6reached crates.io via exactly this recovery route. npm is still on 1.2.4, so it's missing the PIF license metadata and the* Nheader fix — this is what unblocks getting it there.