Skip to content

satdet to use max_size in remove_small_objects#247

Draft
pllim wants to merge 1 commit into
spacetelescope:masterfrom
pllim:skimage-futurewarn
Draft

satdet to use max_size in remove_small_objects#247
pllim wants to merge 1 commit into
spacetelescope:masterfrom
pllim:skimage-futurewarn

Conversation

@pllim
Copy link
Copy Markdown
Collaborator

@pllim pllim commented May 8, 2026

Description

This pull request is to address the non-CI part of #246 (comment)

@pllim
Copy link
Copy Markdown
Collaborator Author

pllim commented May 8, 2026

I thought this patch is not backward compatible but acstools/tests/test_wfc_satdet.py is not failing with this change even when the stable job is still using scikit-image==0.25.2 🤷‍♀️

@dvstark
Copy link
Copy Markdown
Contributor

dvstark commented May 11, 2026

It's not failing because the test never runs detsat. There’s this note at the top of the detsat test file:

“.. note:: Cannot test detsat() because PHT results change from run to run!”

There’s a “probabilistic Hough Transform” that does indeed give slightly different results every time, so the test is only to make sure that the “update_dq” routine works ok. We could perhaps update the test program to run detsat() but not compare against any “truth” results, so at least we can catch errors like this in the future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants