Feature/dm pokes#10
Draft
meiji274 wants to merge 4 commits into
Draft
Conversation
Collaborator
|
@meiji274 to check if these are already in hicat-package2 and then this needs to be moved to the hicat package side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added dm poke commands to testbed/proxies/bmc_dm.py. I structured these functions as methods for the BmcDmProxy class that always return a command (2x1024 length 1d array). I wasn't sure whether to include the extra flexibility to either return a command or a dm shape (34x34 2d array). Maybe could be included as a feature in a future PR.