Remove cppzmq as dependency#312
Draft
ehpor wants to merge 6 commits into
Draft
Conversation
ehpor
force-pushed
the
feature/remove_cppzmq_dependency
branch
from
5fc3c00 to
82c3faa
Compare
ehpor
force-pushed
the
feature/remove_cppzmq_dependency
branch
from
82c3faa to
f4526b5
Compare
This could potentially lead to an infinite loop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cppzmq was the only conda-forge-only dependency during the build of catkit2. This PR removes this dependency and instead converts all code to "normal" C-bindings of ZeroMQ instead. I added a convenience function to work with multipart messages, just like cppzmq does.