CCD-1754 Update logic for reference file location to include full local cache exploration and server queries#1202
Merged
stscieisenhamer merged 5 commits intoMay 11, 2026
Conversation
stscieisenhamer
added
no-changelog-entry-needed
and removed
no-changelog-entry-needed
labels
Collaborator
Author
|
roman regression #1 jwst regression #1 |
hbrown-ST
reviewed
May 11, 2026
| log.verbose('Attempt to contact server for meta information', verbosity=80) | ||
|
|
||
| # If there is a server, get the instrument from there. | ||
| instrument = api.get_file_info(api.get_default_context(observatory='roman'), os.path.basename(refname))['instrument'] |
Collaborator
There was a problem hiding this comment.
This would want observatory='jwst', no?
hbrown-ST
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves CCD-1754
This PR addresses a regression introduce by PR#1201, where syncing any references by name, i.e. the
--filesoption, fails. The core issue is the disconnect between reference file retrieval, which can be just a file name, and where that file is in the CRDS database. The current logic was too simplistic and forced reference names into have a specific information in it. This PR adds the ability to derive the needed information from potentially already-existing files in the local cache or a server if present.Tasks
docs/pageno-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types)news fragment change types...
changes/<PR#>.hst.rst: HST reference fileschanges/<PR#>.jwst.rst: JWST reference fileschanges/<PR#>.roman.rst: Roman reference fileschanges/<PR#>.doc.rst: documentation changechanges/<PR#>.testing.rst: change to tests or test automationchanges/<PR#>.general.rst: infrastructure or miscellaneous change