TST: New api 2#662
Draft
nden wants to merge 7 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #662 +/- ##
=======================================
Coverage 86.18% 86.19%
=======================================
Files 39 39
Lines 4111 4150 +39
=======================================
+ Hits 3543 3577 +34
- Misses 568 573 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JWST regression tests: https://github.com/spacetelescope/RegressionTests/actions/runs/20268196432
Roman regression tests: https://github.com/spacetelescope/RegressionTests/actions/runs/20270632739/job/58206279655
The failing Roman test matches the failure on main.
The romanisim failure is due to a mixup of units in romanisim and galsim. This PR enforces unit conversion and revealed the issue. Fix is in spacetelescope/romanisim#290
This is an alternative to #660. #660 ensures the return type is the same as the input type but does not allow using high level objects (HLO) with the legacy functions. This PR removes the restriction. A summary:
A typical example showing the difference between the two PRs is below. Note that HLO is by definition the type defined in
wcs.world_axis_object_components.With #660
With #662
Example 2:
With #660
With #662