Clean up the internal calls in GWCS#696
Open
WilliamJamieson wants to merge 7 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #696 +/- ##
==========================================
+ Coverage 86.04% 86.07% +0.02%
==========================================
Files 41 41
Lines 4343 4345 +2
==========================================
+ Hits 3737 3740 +3
+ Misses 606 605 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WilliamJamieson
force-pushed
the
Refactor_internal_API
branch
6 times, most recently
from
5bf1217 to
a930d24
Compare
WilliamJamieson
force-pushed
the
Refactor_internal_API
branch
2 times, most recently
from
5e1d55a to
829037f
Compare
WilliamJamieson
force-pushed
the
Refactor_internal_API
branch
from
829037f to
d609d0d
Compare
… evalute and invert
WilliamJamieson
force-pushed
the
Refactor_internal_API
branch
from
d609d0d to
7d478b8
Compare
Need to handle Identity directly rather than trying to infer it.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the code call paths for the GWCS Native API use common code paths instead of effectively replicating code. This way the external API can be more properly expressed and maintained in a consistent fashion. Fix #561
As a byproduct of this work we also fix issues with quantities in the "APE 14 low-level API". Documentation of this will come in a follow on PR. Fix #689
Tasks
gwcstests.docs/page.no-changelog-entry-needed.)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types).News fragment change types:
changes/<PR#>.feature.rst: new featurechanges/<PR#>.breaking.rst: any change or deprecation of the public APIchanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.doc.rst: documentation changechanges/<PR#>.misc.rst: infrastructure or miscellaneous change