solves #726: bug in default inverse mapping#727
Open
0Navin0 wants to merge 1 commit intospacetelescope:mainfrom
Open
solves #726: bug in default inverse mapping#7270Navin0 wants to merge 1 commit intospacetelescope:mainfrom
0Navin0 wants to merge 1 commit intospacetelescope:mainfrom
Conversation
sky2pix_proj can't access the __name__ attribute of the parent class, so explicitly access from the parent class.
Member
|
I suppose tests added in #600 are missing the important block of code that was added in that PR, as well as Could you, please, update or add unit tests to cover this code? |
Member
|
Also, you are using |
Author
Oh sorry. I am still learning my way around Github, so this happened by mistake. Should I create a new feature branch, and then again create a pull request? Any suggestion is appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a bug that triggered when a
backward_transformis not defined and defaultnumerical_inverseneeds to be used.Tasks
no-changelog-entry-neededNews fragment change types:
changes/726.bugfix.rst: fixes an issue