adding check for valid subset name#2610
Draft
cshanahan1 wants to merge 1 commit into
Draft
Conversation
cshanahan1
requested review from
bmorris3,
gibsongreen,
haticekaratay,
javerbukh,
kecnry,
pllim and
rosteen
as code owners
Contributor
|
Since you mentioned that this is a draft, I turned it into draft PR. FYI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Draft PR from hack day).
This adds a function to (eventually) check if a subset name provided when renaming is valid, and raises a warning if it's not (and returns the existing name to prevent renaming).