-
Notifications
You must be signed in to change notification settings - Fork 88
spectrum1d importer to support spectrum list/concatenate #3953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kecnry
wants to merge
26
commits into
spacetelescope:main
Choose a base branch
from
kecnry:spectrum1d-consolidation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c250027 to
4f728dd
Compare
4f728dd to
0ec47c8
Compare
dbb4a9f to
d6f50c8
Compare
d6f50c8 to
2bfb779
Compare
a3be623 to
2256a7f
Compare
2256a7f to
727295d
Compare
* and update UI to indicate when just showing the prefix
* could copy this pattern to other importers as well * could extend this to show when there is a conflict with an existing data-label (and indicate it will overwrite that entry)
3f915ad to
5dc468d
Compare
8ddd253 to
93fd717
Compare
93fd717 to
22bd808
Compare
9f7cb69 to
3288df1
Compare
3288df1 to
a988876
Compare
rosteen
approved these changes
Jan 9, 2026
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't turn up any bugs in testing, and didn't see anything I object to from a quick look at the code. Seems good to me.
Collaborator
|
This is the intermittent Specviz2D failure right, not related? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request absorbs the functionality of
1D Spectrum Listand1D Spectrum List Concatenatedinto1D Spectrumand generalizes the underlying code.TODO: