Skip to content

Conversation

@kecnry
Copy link
Member

@kecnry kecnry commented Dec 18, 2025

Description

This pull request absorbs the functionality of 1D Spectrum List and 1D Spectrum List Concatenated into 1D Spectrum and generalizes the underlying code.

TODO:

  • fix hash support
  • remove/deprecation spectrumlist/concatenate importer?
  • fix concatenation support and ensure test coverage exists
  • ensure WFSS coverage is still in tests
  • fix prefix/not-prefix support for data-label (keeping in mind future plan to add source into default data-label)
  • follow-up: extension select API to clear selection (when to expose this?) with API hint

@kecnry kecnry added this to the 4.6 milestone Dec 18, 2025
@kecnry kecnry force-pushed the spectrum1d-consolidation branch 4 times, most recently from c250027 to 4f728dd Compare December 18, 2025 19:23
@kecnry kecnry force-pushed the spectrum1d-consolidation branch from 4f728dd to 0ec47c8 Compare December 18, 2025 20:11
@kecnry kecnry force-pushed the spectrum1d-consolidation branch from dbb4a9f to d6f50c8 Compare December 19, 2025 17:41
@kecnry kecnry force-pushed the spectrum1d-consolidation branch from d6f50c8 to 2bfb779 Compare December 19, 2025 17:45
@kecnry kecnry force-pushed the spectrum1d-consolidation branch from a3be623 to 2256a7f Compare December 19, 2025 18:31
@kecnry kecnry force-pushed the spectrum1d-consolidation branch from 2256a7f to 727295d Compare December 19, 2025 18:49
* and update UI to indicate when just showing the prefix
* could copy this pattern to other importers as well
* could extend this to show when there is a conflict with an existing data-label (and indicate it will overwrite that entry)
@kecnry kecnry force-pushed the spectrum1d-consolidation branch from 3f915ad to 5dc468d Compare December 19, 2025 19:48
@kecnry kecnry force-pushed the spectrum1d-consolidation branch from 8ddd253 to 93fd717 Compare January 7, 2026 16:38
@kecnry kecnry force-pushed the spectrum1d-consolidation branch from 93fd717 to 22bd808 Compare January 7, 2026 16:40
@kecnry kecnry force-pushed the spectrum1d-consolidation branch from 9f7cb69 to 3288df1 Compare January 7, 2026 17:12
@kecnry kecnry force-pushed the spectrum1d-consolidation branch from 3288df1 to a988876 Compare January 7, 2026 18:33
@kecnry kecnry marked this pull request as ready for review January 7, 2026 19:06
Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't turn up any bugs in testing, and didn't see anything I object to from a quick look at the code. Seems good to me.

@rosteen
Copy link
Collaborator

rosteen commented Jan 9, 2026

This is the intermittent Specviz2D failure right, not related?

FAILED ../../.tox/py311-test-alldeps-cov/lib/python3.11/site-packages/jdaviz/configs/specviz2d/tests/test_parsers.py::test_2d_parser_ext_hdulist - ValueError: ('no valid loaders found for input, tried', {'file': "resolver exception: 'https://stsci.box.com/shared/static/l1dmioxuvtzyuq1p7o9wvjq8pph2yqkk.fits' is not a valid file path.", 'url': "resolver exception: You requested to cache data to the `local_path`='/home/runner/work/jdaviz/jdaviz/.tmp/py311-test-alldeps-cov/.'. This keyword argument is supported for downloads of MAST URIs via astroquery, but since the remote file at 'https://stsci.box.com/shared/static/l1dmioxuvtzyuq1p7o9wvjq8pph2yqkk.fits' will be downloaded using `astropy.utils.data.download_file`, the file will be stored in the astropy download cache instead.", 'object': 'not valid', 'astroquery': 'resolver exception: Resolver subclass must implement default_input', 'virtual observatory': 'resolver exception: Resolver subclass must implement default_input'})

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants