Skip to content

Conversation

@kecnry
Copy link
Member

@kecnry kecnry commented Jan 12, 2026

Description

This pull request replaces the landing page of the docs and reorganizes content preparing for a deconfigged-first release.

Rendered docs

If merging this, we may want to change the default on readthedocs from "latest" to "stable"

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • If new remote data is added that uses MAST, is the URI added to the cache-download.yml workflow?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@github-actions github-actions bot added the documentation Explanation of code and concepts label Jan 12, 2026
@kecnry kecnry added this to the 4.6 milestone Jan 14, 2026
@kecnry kecnry added the no-changelog-entry-needed changelog bot directive label Jan 14, 2026
Copilot AI and others added 4 commits January 15, 2026 12:41
…ction sequencing and multi-instance support (#21)

* Initial plan

* Extract wireframe components and create directive

Co-authored-by: kecnry <[email protected]>

* Update index.html to use external wireframe components

Co-authored-by: kecnry <[email protected]>

* Add wireframe architecture documentation

Co-authored-by: kecnry <[email protected]>

* Add wireframe test page for standalone testing

Co-authored-by: kecnry <[email protected]>

* fix embedding issues

* fix descriptions and API button

* simplify cycle control button

* Add customization options to wireframe directive

- Add 'demo' option to customize cycling order
- Add 'enable-only' option to disable specific toolbar icons
- Add 'show-scroll-to' option to control footer button visibility
- Configure aperture_photometry.rst to only show/enable plugins tab
- Configure index.html to show all features (default)

Co-authored-by: kecnry <[email protected]>

* no need to explicitly set show-scroll-to: false

* fix light styles

* add plugin tray wireframe

* Add plugin customization and demo sequencing

- Add plugin-name option to customize expansion panel name
- Add plugin-panel-opened option to control initial panel state
- Add custom-content option to inject custom HTML (replaces description)
- Add demo sequence support with actions (open-panel, select-data, select-aperture)
- Configure aperture_photometry.rst with custom plugin and demo sequence
- Demo: activate plugins tab -> open panel -> select "Image 2"

Co-authored-by: kecnry <[email protected]>

* per-plugin wireframe demo

* fillout docs content

* Add initial state support and multi-instance capability

- Add :initial: option to set wireframe state before demo starts
- Initial state applied on restart and demo repeat
- Support multiple wireframe instances per page using unique IDs
- Each instance has its own config via data-wireframe-config attribute
- Scoped DOM queries to container to avoid conflicts
- Parse initial state with same syntax as demo sequence

Co-authored-by: kecnry <[email protected]>

* Fix JSON encoding for wireframe config attributes

- Use proper JSON encoding instead of manual string building
- Escape JSON for HTML attributes using html.escape()
- Build config as Python dict then serialize with json.dumps()
- Fixes broken wireframe display on index.html and doc pages

Co-authored-by: kecnry <[email protected]>

* fix multiple instances on one page

* fix changing dropdown after clicking subtab

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: kecnry <[email protected]>
Co-authored-by: Kyle Conroy <[email protected]>
@kecnry kecnry force-pushed the docs-refactor branch 2 times, most recently from 1833014 to 21f6450 Compare January 15, 2026 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Explanation of code and concepts no-changelog-entry-needed changelog bot directive

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant