Skip to content

bugfix: S3 loader#3980

Draft
bmorris3 wants to merge 3 commits intospacetelescope:mainfrom
bmorris3:fix-s3-loader
Draft

bugfix: S3 loader#3980
bmorris3 wants to merge 3 commits intospacetelescope:mainfrom
bmorris3:fix-s3-loader

Conversation

@bmorris3
Copy link
Contributor

@bmorris3 bmorris3 commented Jan 14, 2026

Description

(in progress)

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • If new remote data is added that uses MAST, is the URI added to the cache-download.yml workflow?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@bmorris3 bmorris3 added this to the 4.5.2 milestone Mar 17, 2026
@bmorris3 bmorris3 added the Extra CI Run cron jobs in PR label Mar 18, 2026
@codecov
Copy link

codecov bot commented Mar 18, 2026

Codecov Report

❌ Patch coverage is 28.57143% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.51%. Comparing base (87ea615) to head (35db494).

Files with missing lines Patch % Lines
jdaviz/utils.py 15.78% 16 Missing ⚠️
jdaviz/core/loaders/resolvers/url/url.py 42.85% 4 Missing ⚠️

❌ Your patch check has failed because the patch coverage (28.57%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3980      +/-   ##
==========================================
- Coverage   84.58%   84.51%   -0.08%     
==========================================
  Files         202      202              
  Lines       29487    29511      +24     
==========================================
- Hits        24943    24942       -1     
- Misses       4544     4569      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Extra CI Run cron jobs in PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant