fix: add PyInstaller hook for pythreejs JSON data files#4004
Open
maartenbreddels wants to merge 1 commit into
Open
fix: add PyInstaller hook for pythreejs JSON data files#4004maartenbreddels wants to merge 1 commit into
maartenbreddels wants to merge 1 commit into
Conversation
pythreejs loads JSON shader data files at import time (ShaderChunk, ShaderLib, and UniformsLib). PyInstaller doesn't automatically bundle these data files, causing runtime FileNotFoundError. This hook ensures the JSON files are included in the bundled application.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
pythreejs loads JSON shader data files at import time (ShaderChunk, ShaderLib, and UniformsLib). PyInstaller doesn't automatically bundle these data files, causing runtime FileNotFoundError. This hook ensures the JSON files are included in the bundled application.
Fixes errors like:
https://github.com/spacetelescope/jdaviz/actions/runs/20140106864/job/57804784350?pr=3943
Change log entry
CHANGES.rst? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rstbefore merge. If no, maintainershould add a
no-changelog-entry-neededlabel.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
triviallabel.cache-download.ymlworkflow?