Add SSA and SCS Support to VO Loader#4060
Conversation
|
I pushed up my code as-is to get feedback, as I couldn't get this particular Vuetify trick to work. Any Vuetify expert advise would be greatly appreciated! My original plan was to have the initial dropdown ask the user for "Images" or "Spectra" (that text exactly), but have the underlying value be "sia" or "ssa" respectively for service selection down the line. Based on the Vuetify 2 docs, I should be able to accomplish it this way: jdaviz/jdaviz/core/loaders/resolvers/virtual_observatory/vo.py Lines 27 to 32 in 8309c63 with a small change of swapping "text" with "label" to accommodate Jdaviz's custom plugin-select component defined here: jdaviz/jdaviz/components/plugin_select.vue Lines 18 to 19 in 8309c63 But therein lies a problem: The plugin-select component manually forces the I also cannot tell if this is something that is overridable by the specific component I'm writing. Setting the |
|
we could do that, but then its confusing which (the label or the value) is expected for the user from the API for the select component. Can we just keep the user-friendly label in the UI and API and then map to what is needed for the backend call with an if-statement or dictionary lookup (or perhaps by setting 'object' in the dictionary or similar so the |
Oh okay I understand the catch 22 we're under here...
We definitely can; it just seems like a shame to have to encode this logic if there's a built-in mechanism in Vuetify for this specific purpose. But in lieu of any better options, we might be boxed into this solution... Oh well, I'll rework that logic in this manner hopefully to sidestep this problem |
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (54.54%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #4060 +/- ##
==========================================
+ Coverage 84.57% 84.60% +0.02%
==========================================
Files 205 205
Lines 30414 30418 +4
==========================================
+ Hits 25724 25734 +10
+ Misses 4690 4684 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I don't think the failing tests are my doing; they seem to appear independent. At least the tests I added are passing locally for me. I'll provide this PR for review now! |
Description
This PR extends the VO Loader to add support for IVOA's Simple Spectrum Access protocol and allow Jdaviz to load spectra, and Simple Catalog Search for Catalogs respectively. This is done by adding a dropdown at the very top which requests if users are interested in searching for Images or Spectra, which selects the appropriate protocol to pass to pyvo under the hood.
Tests in progress
Change log entry
CHANGES.rst? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rstbefore merge. If no, maintainershould add a
no-changelog-entry-neededlabel.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
triviallabel.cache-download.ymlworkflow?