Allow cube fit in deconfigged#4172
Open
rosteen wants to merge 6 commits into
Open
Conversation
rosteen
requested review from
bmorris3,
cshanahan1,
gibsongreen and
haticekaratay
as code owners
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (84.21%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #4172 +/- ##
==========================================
- Coverage 84.76% 84.76% -0.01%
==========================================
Files 205 205
Lines 30539 30552 +13
==========================================
+ Hits 25886 25897 +11
- Misses 4653 4655 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rosteen
force-pushed
the
cube-fit-in-deconfigged
branch
from
0edbc4e to
bf63191
Compare
cshanahan1
approved these changes
May 12, 2026
| if self.dataset_selected in self._app.data_collection.labels: | ||
| data = self._app.data_collection[self.dataset_selected] | ||
| else: # User selected some subset from spectrum viewer, just use original cube | ||
| # TODO: generalize this for deconfigged |
Contributor
There was a problem hiding this comment.
is there a ticket for this?
jbchampagne
approved these changes
May 12, 2026
jbchampagne
left a comment
jbchampagne
left a comment
There was a problem hiding this comment.
I tested this out and the issue appears to be fixed, looks good to me!
| if self.dataset_selected in self._app.data_collection.labels: | ||
| data = self._app.data_collection[self.dataset_selected].get_object(statistic=None) | ||
| else: # User selected some subset from spectrum viewer, just use original cube | ||
| # TODO: generalize this for deconfigged |
There was a problem hiding this comment.
does this need a separate ticket from what clare noted?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows the Cube Fit toggle to appear in the Model Fitting plugin when appropriate, and will hide it if the last cube data is deleted from the data collection. Note that I added two
ToDos that I think are beyond the scope of this ticket but should be done to make sure model fitting is behaving properly in deconfigged. Basically, there are a couple places that fall back on assuming the cube was the first data loaded into the app, which isn't necessarily true in deconfigged in the same way it is in Cubeviz.