Fix "learn more" links#4173
Open
rosteen wants to merge 9 commits into
Open
Conversation
github-actions
Bot
added
cubeviz
specviz
imviz
plugin
rosteen
requested review from
MatthewPortman,
bmorris3,
cshanahan1,
gibsongreen,
haticekaratay,
javerbukh and
kecnry
as code owners
rosteen
force-pushed
the
fix-learn-more-links
branch
from
2c4babf to
5f9b76b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4173 +/- ##
==========================================
+ Coverage 84.76% 84.78% +0.02%
==========================================
Files 205 205
Lines 30539 30585 +46
==========================================
+ Hits 25886 25932 +46
Misses 4653 4653 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing logic to point to the config docs (mostly in the vue files) doesn't work for deconfigged. For now I'm overriding in the deconfigged case until we fully deprecate the old configs.