Roman catalog detection#4216
Open
jbchampagne wants to merge 25 commits into
Open
Conversation
cshanahan1
reviewed
Jun 3, 2026
| 'infrared', 'fraction', 'gradient', 'ratio', | ||
| 'integrated,' 'radian', 'random', 'parallax', 'range', | ||
| 'decade', 'decadal', 'decrement', 'deconvolve'] | ||
| 'decade', 'decadal', 'decrement', 'deconvolve', |
Contributor
There was a problem hiding this comment.
i think we may not want to exclude 'psf' here, because source positions may come from psf fitting (*whoops meant to leave this comment on the line below)
Contributor
Author
There was a problem hiding this comment.
good point, removed
cshanahan1
reviewed
Jun 3, 2026
f9e7280 to
04cf746
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4216 +/- ##
==========================================
- Coverage 85.16% 85.15% -0.02%
==========================================
Files 229 229
Lines 31208 31219 +11
==========================================
+ Hits 26579 26583 +4
- Misses 4629 4636 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
MatthewPortman
approved these changes
Jun 4, 2026
cshanahan1
approved these changes
Jun 5, 2026
cshanahan1
left a comment
Contributor
There was a problem hiding this comment.
looks good, approved pending confirmation that all test failures are known issues
4a9f2ff to
e6e638a
Compare
# Conflicts: # CHANGES.rst
* Add clarifying hint about table query toggle * Add toggle to limit results to science type files * Add changelog * Only filter type if it's in the table * Only show science filter for astroquery * Add option back to user API # Conflicts: # CHANGES.rst
Co-authored-by: Matthew Portman <29168957+MatthewPortman@users.noreply.github.com>
e3d7619 to
f8bbdb4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the CatalogImporter to detect ra/dec/x/y columns when there are multiple columns that satisfy the requirements to be coordinates, such as 'ra', 'ra_centroid', 'ra_err', etc. This is in preparation for Roman source catalogs which will include various quantities from the source extraction procedure, including positional uncertainties. Uncertainty or min/max columns should be excluded. The intended behavior is to default to the first (non-excluded) match. Added test coverage for input catalogs with multiple coordinate options.
Fixes #JDAT-6141
Change log entry
CHANGES.rst? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rstbefore merge. If no, maintainershould add a
no-changelog-entry-neededlabel.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
triviallabel.cache-download.ymlworkflow?