Skip to content

Conversation

@melanieclarke
Copy link
Collaborator

@melanieclarke melanieclarke commented Jan 16, 2026

Partially resolves JP-4192

Update the extract_2d step to use prepare_output

Tasks

  • If you have a specific reviewer in mind, tag them.
  • add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
      • if your change breaks step-level or public API (as defined in the docs), also add a changes/<PR#>.breaking.rst news fragment
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.31%. Comparing base (bbf1e5f) to head (e2a9843).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10157      +/-   ##
==========================================
+ Coverage   85.98%   86.31%   +0.33%     
==========================================
  Files         368      366       -2     
  Lines       38457    38435      -22     
==========================================
+ Hits        33066    33176     +110     
+ Misses       5391     5259     -132     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@melanieclarke
Copy link
Collaborator Author

Regtests:
https://github.com/spacetelescope/RegressionTests/actions/runs/21184839415

All passing. No memory improvements because this step did not previously copy its input: it makes a new datamodel.

@melanieclarke melanieclarke marked this pull request as ready for review January 20, 2026 21:45
@melanieclarke melanieclarke requested a review from a team January 20, 2026 21:45
@melanieclarke melanieclarke merged commit 2ed4130 into spacetelescope:main Jan 20, 2026
28 checks passed
@melanieclarke melanieclarke deleted the jp-4192-extract_2d branch January 20, 2026 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants