Skip to content

DOC: Complete API for gain_scale#10424

Merged
melanieclarke merged 2 commits into
spacetelescope:mainfrom
pllim:no-pain-no-gain
Apr 8, 2026
Merged

DOC: Complete API for gain_scale#10424
melanieclarke merged 2 commits into
spacetelescope:mainfrom
pllim:no-pain-no-gain

Conversation

@pllim
Copy link
Copy Markdown
Collaborator

@pllim pllim commented Apr 6, 2026

Towards JP-4107

This PR addresses gain_scale portion of #9793 . Only touch docs so should not need RT.

On main:

With this patch:

Tasks

  • If you have a specific reviewer in mind, tag them.
  • add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
      • if your change breaks step-level or public API (as defined in the docs), also add a changes/<PR#>.breaking.rst news fragment
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

Comment thread docs/jwst/gain_scale/arguments.rst Outdated
@pllim pllim marked this pull request as ready for review April 6, 2026 21:20
@pllim pllim requested a review from a team April 6, 2026 21:20
@pllim pllim requested a review from kmacdonald-stsci as a code owner April 6, 2026 21:20
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.76%. Comparing base (95af53b) to head (9d84c76).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10424   +/-   ##
=======================================
  Coverage   85.76%   85.76%           
=======================================
  Files         372      372           
  Lines       40032    40032           
=======================================
  Hits        34334    34334           
  Misses       5698     5698           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@melanieclarke melanieclarke added this to the Build 13.0 milestone Apr 8, 2026
@melanieclarke melanieclarke enabled auto-merge (squash) April 8, 2026 19:43
@melanieclarke melanieclarke merged commit 61678e3 into spacetelescope:main Apr 8, 2026
30 checks passed
@pllim pllim deleted the no-pain-no-gain branch April 8, 2026 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants