Skip to content

DOC: Complete API for guider_cds#10426

Merged
melanieclarke merged 3 commits into
spacetelescope:mainfrom
pllim:hitchhiker-guider-to-the-galaxy
Apr 17, 2026
Merged

DOC: Complete API for guider_cds#10426
melanieclarke merged 3 commits into
spacetelescope:mainfrom
pllim:hitchhiker-guider-to-the-galaxy

Conversation

@pllim
Copy link
Copy Markdown
Collaborator

@pllim pllim commented Apr 6, 2026

Towards JP-4107

This PR addresses guider_cds portion of #9793 . Only touch docs so should not need RT.

On main:

With this patch:

Tasks

  • If you have a specific reviewer in mind, tag them.
  • add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
      • if your change breaks step-level or public API (as defined in the docs), also add a changes/<PR#>.breaking.rst news fragment
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

Comment thread docs/jwst/guider_cds/arguments.rst Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.16%. Comparing base (c092c43) to head (9bf1826).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10426   +/-   ##
=======================================
  Coverage   86.16%   86.16%           
=======================================
  Files         372      372           
  Lines       40091    40091           
=======================================
  Hits        34543    34543           
  Misses       5548     5548           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pllim pllim marked this pull request as ready for review April 7, 2026 13:58
@pllim pllim requested a review from a team April 7, 2026 13:58
@pllim pllim requested a review from tapastro as a code owner April 7, 2026 13:58
@melanieclarke melanieclarke added this to the Build 13.0 milestone Apr 17, 2026
Copy link
Copy Markdown
Collaborator

@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the extra organization!

@melanieclarke melanieclarke enabled auto-merge (squash) April 17, 2026 20:58
@melanieclarke melanieclarke merged commit abf0ba7 into spacetelescope:main Apr 17, 2026
30 checks passed
@pllim pllim deleted the hitchhiker-guider-to-the-galaxy branch April 27, 2026 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants