JP-4224: Remove correction_pars#10432
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10432 +/- ##
==========================================
- Coverage 86.40% 86.38% -0.02%
==========================================
Files 373 373
Lines 40112 40062 -50
==========================================
- Hits 34658 34608 -50
Misses 5454 5454 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
I'm in favor of moving forward here. Just needs a conflict to be resolved and to be pulled out of draft. |
Collaborator
Author
|
New regression test run: Just the one expected header diff, for the master_background_mos test. |
tapastro
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves JP-4224
Remove unnecessary storage of correction models as an attribute on the following steps: flat_field, pathloss, barshadow, photom, and master_background_mos.
Just recomputing the corrections instead of storing them only adds a small amount of processing time to the master_background_mos step (~4s running the regtest example locally), but it improves peak memory use in stage 2 for all modes that use these steps.
Discussion still needed about whether we need to deprecate these attributes. So far, I have just removed them, but I can add deprecation support back in.
This PR is built on top of #10421, since they touch the same step and the additional unit test coverage was useful here. I can separate them out if need be.(those changes have been merged; this PR is rebased)Initial regression tests here:
https://github.com/spacetelescope/RegressionTests/actions/runs/24090988005
There is one header diff for master background MOS processing, because the interpolated flat is recreated instead of provided as a custom reference file. I think the existing value was misleading anyway. Also shows memory improvements above the threshold for NIRCam imaging and spectra as well as NIRISS SOSS.
Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)changes/<PR#>.breaking.rstnews fragmentdocs/pageokify_regteststo update the truth files