Skip to content

JP-4267: Add U4COORD and V4COORD to oifits model#10434

Merged
emolter merged 4 commits into
spacetelescope:mainfrom
emolter:JP-4267
Apr 15, 2026
Merged

JP-4267: Add U4COORD and V4COORD to oifits model#10434
emolter merged 4 commits into
spacetelescope:mainfrom
emolter:JP-4267

Conversation

@emolter
Copy link
Copy Markdown
Collaborator

@emolter emolter commented Apr 7, 2026

Resolves JP-4267

Requires spacetelescope/stdatamodels#709 and some unit tests are expected to fail in the CI but pass on the regression tests pointed to that branch.

This PR adds u4coord and v4coord values to the oifits model q4 tables.

Tasks

  • If you have a specific reviewer in mind, tag them.
  • add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
      • if your change breaks step-level or public API (as defined in the docs), also add a changes/<PR#>.breaking.rst news fragment
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@emolter
Copy link
Copy Markdown
Collaborator Author

emolter commented Apr 7, 2026

https://github.com/spacetelescope/RegressionTests/actions/runs/24097513550 points to the stdatamodels pr branch

Differences are expected: AMI OI models have a new column.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.76%. Comparing base (f1663e1) to head (d4b5936).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10434      +/-   ##
==========================================
- Coverage   85.77%   85.76%   -0.01%     
==========================================
  Files         372      372              
  Lines       40060    40062       +2     
==========================================
+ Hits        34360    34361       +1     
- Misses       5700     5701       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@emolter emolter marked this pull request as ready for review April 7, 2026 20:08
@emolter emolter requested a review from a team April 7, 2026 20:08
Copy link
Copy Markdown
Collaborator

@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! I'll leave coordination for the merge and okify to you.

@emolter emolter enabled auto-merge (squash) April 15, 2026 14:09
@emolter emolter merged commit 4af2af6 into spacetelescope:main Apr 15, 2026
41 of 42 checks passed
@emolter emolter deleted the JP-4267 branch April 15, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants