Skip to content

DOC: Complete API for master_background#10440

Merged
melanieclarke merged 4 commits into
spacetelescope:mainfrom
pllim:masters-of-the-universe-background
Apr 28, 2026
Merged

DOC: Complete API for master_background#10440
melanieclarke merged 4 commits into
spacetelescope:mainfrom
pllim:masters-of-the-universe-background

Conversation

@pllim
Copy link
Copy Markdown
Collaborator

@pllim pllim commented Apr 8, 2026

Towards JP-4107

This PR addresses master_background portion of #9793 . Only touch docs so should not need RT.

On main:

With this patch:

Tasks

  • If you have a specific reviewer in mind, tag them.
  • add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
      • if your change breaks step-level or public API (as defined in the docs), also add a changes/<PR#>.breaking.rst news fragment
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.18%. Comparing base (a6c3a43) to head (af308ea).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10440      +/-   ##
==========================================
- Coverage   86.19%   86.18%   -0.01%     
==========================================
  Files         372      372              
  Lines       40103    40103              
==========================================
- Hits        34565    34564       -1     
- Misses       5538     5539       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pllim pllim force-pushed the masters-of-the-universe-background branch from b993a96 to 1e321d7 Compare April 8, 2026 19:58
@pllim pllim marked this pull request as ready for review April 8, 2026 20:38
@pllim pllim requested a review from a team April 8, 2026 20:38
@melanieclarke melanieclarke added this to the Build 13.0 milestone Apr 17, 2026
Copy link
Copy Markdown
Collaborator

@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small suggestions for this one.

Comment thread docs/jwst/master_background/description.rst Outdated
Comment thread docs/jwst/master_background/description.rst Outdated
Comment thread docs/jwst/master_background/description.rst Outdated
@pllim pllim force-pushed the masters-of-the-universe-background branch from b9a437f to 3da7de0 Compare April 27, 2026 21:31
pllim and others added 2 commits April 27, 2026 17:32
(part 1 of 2)

[ci skip]

Co-authored-by: Melanie Clarke <mclarke@stsci.edu>
Copy link
Copy Markdown
Collaborator

@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I'm still hoping we'll get a CRDS fix soon to get CI passing again. I'll get this in soon after.

@melanieclarke melanieclarke enabled auto-merge (squash) April 28, 2026 21:37
@melanieclarke melanieclarke merged commit 745bf6b into spacetelescope:main Apr 28, 2026
30 checks passed
@pllim pllim deleted the masters-of-the-universe-background branch April 29, 2026 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants