Skip to content

JP-4289: Define supported SOSS subarrays in jwst.lib#10451

Merged
melanieclarke merged 2 commits into
spacetelescope:mainfrom
melanieclarke:jp-4289-soss_subarrays
Apr 16, 2026
Merged

JP-4289: Define supported SOSS subarrays in jwst.lib#10451
melanieclarke merged 2 commits into
spacetelescope:mainfrom
melanieclarke:jp-4289-soss_subarrays

Conversation

@melanieclarke
Copy link
Copy Markdown
Collaborator

@melanieclarke melanieclarke commented Apr 14, 2026

Toward JP-4289

Add a list of supported SOSS subarrays to jwst.lib.exposure_types and use it to replace some duplicated hard-coded lists in various places.

This seemed like a reasonable place to define the list, since there are other similar constants in that module, but I'm open to suggestions if somewhere else is preferable.

I also added the existing constants to __all__ since they are imported elsewhere.

Tasks

  • If you have a specific reviewer in mind, tag them.
  • add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
      • if your change breaks step-level or public API (as defined in the docs), also add a changes/<PR#>.breaking.rst news fragment
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@melanieclarke
Copy link
Copy Markdown
Collaborator Author

melanieclarke commented Apr 14, 2026

Regression tests:
https://github.com/spacetelescope/RegressionTests/actions/runs/24414295232

A couple unrelated failures from network blips; otherwise, all passing.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.77%. Comparing base (7c18ede) to head (cff6ce9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10451   +/-   ##
=======================================
  Coverage   85.76%   85.77%           
=======================================
  Files         372      372           
  Lines       40062    40065    +3     
=======================================
+ Hits        34361    34364    +3     
  Misses       5701     5701           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@melanieclarke melanieclarke marked this pull request as ready for review April 14, 2026 18:49
@melanieclarke melanieclarke requested a review from a team April 14, 2026 18:49
Copy link
Copy Markdown
Collaborator

@emolter emolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up! My only comment/question is whether you think exposure_types is an ok namespace for subarrays, or if it's a technicality not worth worrying about

@melanieclarke
Copy link
Copy Markdown
Collaborator Author

Thanks for cleaning up! My only comment/question is whether you think exposure_types is an ok namespace for subarrays, or if it's a technicality not worth worrying about

I thought it was close enough -- "exposures with acceptable subarrays" is a sort of sub-type for NIRISS SOSS. Maybe someday we can work on reorganizing the lib utilities to make more meaningful namespaces.

@melanieclarke melanieclarke enabled auto-merge (squash) April 16, 2026 15:50
@melanieclarke melanieclarke merged commit 34543ea into spacetelescope:main Apr 16, 2026
41 of 42 checks passed
@melanieclarke melanieclarke deleted the jp-4289-soss_subarrays branch April 16, 2026 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants