JP-4289: Define supported SOSS subarrays in jwst.lib#10451
Conversation
|
Regression tests: A couple unrelated failures from network blips; otherwise, all passing. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10451 +/- ##
=======================================
Coverage 85.76% 85.77%
=======================================
Files 372 372
Lines 40062 40065 +3
=======================================
+ Hits 34361 34364 +3
Misses 5701 5701 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
emolter
left a comment
There was a problem hiding this comment.
Thanks for cleaning up! My only comment/question is whether you think exposure_types is an ok namespace for subarrays, or if it's a technicality not worth worrying about
I thought it was close enough -- "exposures with acceptable subarrays" is a sort of sub-type for NIRISS SOSS. Maybe someday we can work on reorganizing the lib utilities to make more meaningful namespaces. |
Toward JP-4289
Add a list of supported SOSS subarrays to jwst.lib.exposure_types and use it to replace some duplicated hard-coded lists in various places.
This seemed like a reasonable place to define the list, since there are other similar constants in that module, but I'm open to suggestions if somewhere else is preferable.
I also added the existing constants to
__all__since they are imported elsewhere.Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)changes/<PR#>.breaking.rstnews fragmentdocs/pageokify_regteststo update the truth files