JP-4323: Improve performance of tso median calculation in outlier detection#10452
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10452 +/- ##
==========================================
- Coverage 85.77% 85.76% -0.01%
==========================================
Files 372 372
Lines 40065 40063 -2
==========================================
- Hits 34364 34362 -2
Misses 5701 5701 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
emolter
reviewed
Apr 15, 2026
emolter
reviewed
Apr 15, 2026
Collaborator
emolter
left a comment
There was a problem hiding this comment.
Code LGTM just one comment about the changelog
emolter
approved these changes
Apr 15, 2026
Collaborator
|
Ah, this is probably why I had to put the SOSS notebook onto a 64 GB github CI runner. Great to see the lower memory footprint plus faster runtime, thanks! |
Collaborator
melanieclarke
left a comment
There was a problem hiding this comment.
Looks good, thank you! One small request for more explanation.
melanieclarke
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves JP-4323
On main
jwst/regtest/test_miri_image_tso.py::test_log_tracked_resources_miri_image_tso(based on regtest runs):With this PR the test:
Running the same test locally the runtime pattern agrees (95 on main, 33 with PR).
Regtests: https://github.com/spacetelescope/RegressionTests/actions/runs/24400023732

all pass. Here's a plot of the memory usage for the latest run:
We still have something leaking but at least the peak is reduced.
Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)changes/<PR#>.breaking.rstnews fragmentdocs/pageokify_regteststo update the truth files