Skip to content

JP-4258: Polynomial fitting of simulated source SEDs for wfss_contam#10458

Open
emolter wants to merge 49 commits into
spacetelescope:mainfrom
emolter:JP-4258
Open

JP-4258: Polynomial fitting of simulated source SEDs for wfss_contam#10458
emolter wants to merge 49 commits into
spacetelescope:mainfrom
emolter:JP-4258

Conversation

@emolter
Copy link
Copy Markdown
Collaborator

@emolter emolter commented Apr 16, 2026

Resolves JP-4258

This PR adds optional spectral fitting to the wfss_contam step.

The basic setup is intended to mimic what's done by the GRIZLI code. See the new docs pages and docstrings for a short description of how it works. See the ticket for some figures that demonstrate the capability.

Tasks

  • If you have a specific reviewer in mind, tag them.
  • add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
      • if your change breaks step-level or public API (as defined in the docs), also add a changes/<PR#>.breaking.rst news fragment
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

emolter added 21 commits March 31, 2026 12:48
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2026

Codecov Report

❌ Patch coverage is 95.52239% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.21%. Comparing base (745bf6b) to head (1a87293).

Files with missing lines Patch % Lines
jwst/wfss_contam/wfss_contam.py 95.49% 5 Missing ⚠️
jwst/wfss_contam/wavefit.py 92.15% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10458      +/-   ##
==========================================
+ Coverage   86.18%   86.21%   +0.03%     
==========================================
  Files         372      373       +1     
  Lines       40103    40256     +153     
==========================================
+ Hits        34564    34708     +144     
- Misses       5539     5548       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@emolter emolter modified the milestone: Build 13.0 Apr 27, 2026
@emolter
Copy link
Copy Markdown
Collaborator Author

emolter commented Apr 28, 2026

initial regression test round: https://github.com/spacetelescope/RegressionTests/actions/runs/25075045516

All passing, which is expected because this is not supposed to affect the case without PSF modeling.

@emolter emolter requested review from gnoir0t and tapastro April 29, 2026 13:39
@emolter emolter marked this pull request as ready for review April 29, 2026 14:40
@emolter emolter requested a review from a team April 29, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant