JP-4258: Polynomial fitting of simulated source SEDs for wfss_contam#10458
Open
emolter wants to merge 49 commits into
Open
JP-4258: Polynomial fitting of simulated source SEDs for wfss_contam#10458emolter wants to merge 49 commits into
emolter wants to merge 49 commits into
Conversation
…er return function
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10458 +/- ##
==========================================
+ Coverage 86.18% 86.21% +0.03%
==========================================
Files 372 373 +1
Lines 40103 40256 +153
==========================================
+ Hits 34564 34708 +144
- Misses 5539 5548 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
initial regression test round: https://github.com/spacetelescope/RegressionTests/actions/runs/25075045516 All passing, which is expected because this is not supposed to affect the case without PSF modeling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves JP-4258
This PR adds optional spectral fitting to the wfss_contam step.
The basic setup is intended to mimic what's done by the GRIZLI code. See the new docs pages and docstrings for a short description of how it works. See the ticket for some figures that demonstrate the capability.
Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)changes/<PR#>.breaking.rstnews fragmentdocs/pageokify_regteststo update the truth files