Skip to content

JP-4273: Expect multiple apertures for PSF reference file#10516

Open
melanieclarke wants to merge 2 commits into
spacetelescope:mainfrom
melanieclarke:jp-4273
Open

JP-4273: Expect multiple apertures for PSF reference file#10516
melanieclarke wants to merge 2 commits into
spacetelescope:mainfrom
melanieclarke:jp-4273

Conversation

@melanieclarke
Copy link
Copy Markdown
Collaborator

@melanieclarke melanieclarke commented May 6, 2026

Resolves JP-4273

Update handling for spectral PSF reference files, to match a new schema. This is necessary to support optimal extraction for NIRSpec, which needs to provide PSFs for multiple slits in the same reference file.

Requires spacetelescope/stdatamodels#734

Tasks

  • If you have a specific reviewer in mind, tag them.
  • add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
      • if your change breaks step-level or public API (as defined in the docs), also add a changes/<PR#>.breaking.rst news fragment
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.39%. Comparing base (a5eb979) to head (f5b36ae).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10516   +/-   ##
=======================================
  Coverage   86.38%   86.39%           
=======================================
  Files         373      373           
  Lines       40068    40077    +9     
=======================================
+ Hits        34614    34623    +9     
  Misses       5454     5454           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@melanieclarke
Copy link
Copy Markdown
Collaborator Author

melanieclarke commented May 7, 2026

@melanieclarke melanieclarke marked this pull request as ready for review May 11, 2026 16:47
@melanieclarke melanieclarke requested a review from a team May 11, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant