JP-4273: Expect multiple apertures for PSF reference file#10516
Open
melanieclarke wants to merge 2 commits into
Open
JP-4273: Expect multiple apertures for PSF reference file#10516melanieclarke wants to merge 2 commits into
melanieclarke wants to merge 2 commits into
Conversation
5 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10516 +/- ##
=======================================
Coverage 86.38% 86.39%
=======================================
Files 373 373
Lines 40068 40077 +9
=======================================
+ Hits 34614 34623 +9
Misses 5454 5454 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Regtests: https://github.com/spacetelescope/RegressionTests/actions/runs/25517109460 All passing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves JP-4273
Update handling for spectral PSF reference files, to match a new schema. This is necessary to support optimal extraction for NIRSpec, which needs to provide PSFs for multiple slits in the same reference file.
Requires spacetelescope/stdatamodels#734
Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)changes/<PR#>.breaking.rstnews fragmentdocs/pageokify_regteststo update the truth files