Update resampled output image's background level and status#10525
Open
mcara wants to merge 1 commit into
Open
Conversation
a588ee8 to
cc96c29
Compare
emolter
approved these changes
May 7, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10525 +/- ##
=======================================
Coverage 86.38% 86.38%
=======================================
Files 373 373
Lines 40068 40070 +2
=======================================
+ Hits 34612 34614 +2
Misses 5456 5456 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
emolter
reviewed
May 7, 2026
Member
Author
|
@emolter link to the regression tests is at the bottom of the first comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves JP-4350
When attempting to resample (again) an already resampled image, the resulting double-resampled image often has an unexplained background offset compared to expected (single-resampled) image. After analysis, this is caused by resample populating most meta of the output resampled image from an input cal image and not updating background-related fields.
Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)changes/<PR#>.breaking.rstnews fragmentdocs/pageokify_regteststo update the truth filesRegression tests started: https://github.com/spacetelescope/RegressionTests/actions/runs/25517340890 Expect failures due to mismatches in resampled image background value (in
metaonly) and status (subtracted or not).