JP-4370: Unset S_REGION if wcs is not sky-like#10586
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10586 +/- ##
=======================================
Coverage 86.58% 86.58%
=======================================
Files 374 374
Lines 40443 40453 +10
=======================================
+ Hits 35018 35027 +9
- Misses 5425 5426 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Regtests: Results are as expected. NIRSpec lamp exposures no longer have S_REGION keywords after assign_wcs. Other products are not affected. |
mcara
reviewed
Jun 3, 2026
mcara
approved these changes
Jun 3, 2026
tapastro
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves JP-4370
NIRSpec lamp exposures are resampled in the MSA frame, not in RA/Dec, so they should not have a celestial S_REGION assigned after assign_wcs.
This PR uses a utility that checks the output coordinate frame for the WCS to see if any of its units are sky-like (degrees or arcsec). This utility was previously in the
resamplemodule; I moved it to theassign_wcs.utilmodule, near the s_region utility functions used in multiple places.Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)changes/<PR#>.breaking.rstnews fragmentdocs/pageokify_regteststo update the truth files