JP-4241: Add trace model to tso3#10596
Conversation
9cd2bbf to
8109044
Compare
ab713b4 to
cbfb583
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10596 +/- ##
=======================================
Coverage 86.58% 86.59%
=======================================
Files 374 374
Lines 40455 40471 +16
=======================================
+ Hits 35029 35045 +16
Misses 5426 5426 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Regtests: Diffs for tso3 are as expected: there is a new cal_step status keyword, set to SKIPPED. Truth files are up-to-date for the new test, including the fix for intermediate file names. There are also some unrelated diffs for MIRI WFSS in spec2, for a new background reference file. When those are okified, I'll run again. |
tapastro
left a comment
There was a problem hiding this comment.
Changes look clean and clear, with one slight exception being that handling of adding the asn_id moving around a bit - presumably to handle cases where the input isn't a ModelContainer? Seems fine to merge if tests are behaving as they are.
Yes, that was specifically for tso3 accommodation. In that case, the steps are not run on a ModelContainer, but the ASN ID is available from the parent |
|
Regtests for okifying here: |
Toward JP-4241
Follow up to #10264 to add the trace model step to the tso3 pipeline for spectral TSO processing. This will be necessary for supporting the trace model in
pixel_replacefor TSO spectra.This also necessitated some clean up in the tso3 processing:
Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)changes/<PR#>.breaking.rstnews fragmentdocs/pageokify_regteststo update the truth files