Remove unused niriss_bounding_box function from assign_wcs#9399
Conversation
|
starting regtests here https://github.com/spacetelescope/RegressionTests/actions/runs/14519057977 |
|
I think @nden mentioned that we do not want to remove this - there are still some plans to use it for NIRISS. |
|
Are you talking about #9256 (comment) ? That is not what I got from the discussion - I assumed the comment by @Rplesha would be relatively definitive w.r.t. whether this was desired. If that's wrong, I'm happy to close this PR as well as the GitHub issue, but let's figure out what's desired one way or the other. |
|
No, Nadia mentioned to me in an offline conversation that she still had plans for it, for WCS implementation purposes. It's possible I misunderstood, but hold off on this one until we hear from her, please. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9399 +/- ##
=======================================
Coverage 75.37% 75.37%
=======================================
Files 368 368
Lines 36885 36880 -5
=======================================
- Hits 27802 27800 -2
+ Misses 9083 9080 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Closing in favor of #9456 |
Resolves JP-3970
This PR addresses removal of the unused
niriss_bounding_boxfunction fromassign_wcs.Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)docs/pageokify_regteststo update the truth files