Skip to content

subscriptions in the MAST API#159

Merged
ttdu merged 14 commits into
spacetelescope:mainfrom
ttdu:subscriptions-json
May 22, 2026
Merged

subscriptions in the MAST API#159
ttdu merged 14 commits into
spacetelescope:mainfrom
ttdu:subscriptions-json

Conversation

@ttdu

@ttdu ttdu commented May 5, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@ttdu

ttdu commented May 5, 2026

Copy link
Copy Markdown
Collaborator Author

@snbianco the rest of the notebook is not ready for review, but I wanted to ask about the MissionsMast class defaulting to HST. in this case, when I forgot to set the mission, it tried to download the files and ended up with a lot of nonsense, because the JWST URIs don't work for HST.

what do you think about throwing an error when users don't initialize the mission, instead of defaulting to HST?

@snbianco

snbianco commented May 6, 2026

Copy link
Copy Markdown
Contributor

I may be able to do one better. I notice in the subscription JSON that mission is included. I could make it so that AQ uses that value and defaults to the mission attribute if it's not present (and fails gracefully if that doesn't work either). There's a few things I want to finish first, but I should be able to make a PR sometime this sprint.

@ttdu ttdu force-pushed the subscriptions-json branch from 0cb06cf to 99158b6 Compare May 6, 2026 20:37
@ttdu ttdu marked this pull request as ready for review May 21, 2026 17:45
@ttdu ttdu requested review from adrianlucy and snbianco as code owners May 21, 2026 17:45
@ttdu

ttdu commented May 21, 2026

Copy link
Copy Markdown
Collaborator Author

calling @snbianco for review!

Comment thread notebooks/multi_mission/subscriptions/subscriptions.ipynb Outdated
Comment thread notebooks/multi_mission/subscriptions/subscriptions.ipynb Outdated
Comment thread notebooks/multi_mission/subscriptions/subscriptions.ipynb Outdated
Comment thread notebooks/multi_mission/subscriptions/subscriptions.ipynb
Comment thread notebooks/multi_mission/subscriptions/subscriptions.ipynb Outdated
Comment thread notebooks/multi_mission/subscriptions/subscriptions.ipynb Outdated
Comment thread notebooks/multi_mission/subscriptions/subscriptions.ipynb Outdated
Co-authored-by: Sam Bianco <70121323+snbianco@users.noreply.github.com>
Comment thread notebooks/multi_mission/subscriptions/subscriptions.ipynb Outdated
Comment thread notebooks/multi_mission/subscriptions/subscriptions.ipynb Outdated
Comment thread notebooks/multi_mission/subscriptions/subscriptions.ipynb
Comment thread notebooks/multi_mission/subscriptions/subscriptions.ipynb Outdated
Comment thread notebooks/multi_mission/subscriptions/subscriptions.ipynb
Comment thread notebooks/multi_mission/subscriptions/subscriptions.ipynb Outdated
Comment thread notebooks/multi_mission/subscriptions/subscriptions.ipynb Outdated
Comment thread notebooks/multi_mission/subscriptions/subscriptions.ipynb Outdated
Comment thread notebooks/multi_mission/subscriptions/subscriptions.ipynb
Comment thread notebooks/multi_mission/subscriptions/subscriptions.ipynb Outdated
Comment thread notebooks/multi_mission/subscriptions/subscriptions.ipynb Outdated
@ttdu ttdu merged commit 93379f6 into spacetelescope:main May 22, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants