Skip to content

RAD-272: Add dust map column to source catalog table.#877

Merged
PaulHuwe merged 3 commits into
spacetelescope:mainfrom
PaulHuwe:RAD-272_DustMap
May 13, 2026
Merged

RAD-272: Add dust map column to source catalog table.#877
PaulHuwe merged 3 commits into
spacetelescope:mainfrom
PaulHuwe:RAD-272_DustMap

Conversation

@PaulHuwe

Copy link
Copy Markdown
Collaborator

Resolves RAD-272

Closes #871

This PR incorporates v2.0.0 changes and thus supplants #870

This PR adds a new column to the source catalog table containing information about the estimated dust extinction in B-V, taken by default from the map of Schlegel, Finkbeiner, and Davis (1998).

Tasks

  • Update or add relevant rad tests.
  • Update relevant docstrings and / or docs/ page.
  • Does this PR change any schema files?
    • Schema changes were discussed at RAD Review Board meeting.
  • Does this PR change any API used downstream? (If not, label with no-changelog-entry-needed.)
News fragment change types:
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@PaulHuwe PaulHuwe marked this pull request as ready for review May 11, 2026 23:54
@PaulHuwe PaulHuwe requested review from a team and WilliamJamieson as code owners May 11, 2026 23:54
@codecov

codecov Bot commented May 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.03%. Comparing base (5e16410) to head (276d073).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #877      +/-   ##
==========================================
- Coverage   86.56%   86.03%   -0.54%     
==========================================
  Files          15       15              
  Lines        1154     1131      -23     
==========================================
- Hits          999      973      -26     
- Misses        155      158       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@braingram

Copy link
Copy Markdown
Collaborator

Would you include the "make the column required" changes?
3addce1

@PaulHuwe

Copy link
Copy Markdown
Collaborator Author

Would you include the "make the column required" changes? 3addce1

Added

@mairanteodoro mairanteodoro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We should also update the truth files later on.
Thanks, Paul!

@mairanteodoro

Copy link
Copy Markdown
Contributor

@PaulHuwe Could you add the regression test results to this PR: https://github.com/spacetelescope/RegressionTests/actions/runs/25746150125

@PaulHuwe PaulHuwe merged commit 7fa8290 into spacetelescope:main May 13, 2026
20 of 22 checks passed
@PaulHuwe PaulHuwe deleted the RAD-272_DustMap branch May 13, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add dust map column to the source catalog table.

4 participants