Update to support changing ref file patternProperties to explicit #577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #577 +/- ##
==========================================
- Coverage 97.56% 95.54% -2.02%
==========================================
Files 30 41 +11
Lines 2788 4314 +1526
==========================================
+ Hits 2720 4122 +1402
- Misses 68 192 +124 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8 tasks
WilliamJamieson
force-pushed
the
explicit_pattern_properties
branch
from
666169e to
fe44512
Compare
WilliamJamieson
force-pushed
the
explicit_pattern_properties
branch
3 times, most recently
from
d6d074c to
b9cbcbf
Compare
WilliamJamieson
force-pushed
the
explicit_pattern_properties
branch
from
b9cbcbf to
34eb4ae
Compare
WilliamJamieson
force-pushed
the
explicit_pattern_properties
branch
from
38c7737 to
6944c90
Compare
braingram
requested changes
Oct 13, 2025
Collaborator
braingram
left a comment
braingram
left a comment
There was a problem hiding this comment.
The version checks don't work with dev versions and make unsafe assumptions about asdf.
Comment on lines
+46
to
+47
| # See Issue https://github.com/asdf-format/asdf/issues/1977 | ||
| if Version(asdf.__version__) < Version("5.1.0"): |
Collaborator
There was a problem hiding this comment.
Suggested change
| # See Issue https://github.com/asdf-format/asdf/issues/1977 | |
| if Version(asdf.__version__) < Version("5.1.0"): | |
| # See Issue https://github.com/asdf-format/asdf/issues/1977 | |
| if Version(asdf.__version__) < Version("5.1.0"): |
This assumes a fix will be in asdf 5.1.0 which is not a safe assumption. I will follow up on the issue.
| if TYPE_CHECKING: | ||
| from typing import Any | ||
|
|
||
| if Version(asdf.__version__) < Version("5.0.0"): |
Collaborator
There was a problem hiding this comment.
Suggested change
| if Version(asdf.__version__) < Version("5.0.0"): | |
| if Version(asdf.__version__) < Version("5.0.0"): |
This fails for dev asdf version strings:
>> Version("5.1.1.dev0+g0e7c50c73.d20251013")
ValueError: Invalid version string: '5.1.1.dev0+g0e7c50c73.d20251013'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the downstream change for spacetelescope/rad#712.
Tasks
roman_datamodelstests.docs/page.no-changelog-entry-needed.)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types).romancalregression test (https://github.com/spacetelescope/RegressionTests/actions/workflows/romancal.yml) with this branch installed ("git+https://github.com/<fork>/rad@<branch>").News fragment change types:
changes/<PR#>.feature.rst: new featurechanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.doc.rst: documentation changechanges/<PR#>.removal.rst: deprecation or removal of public APIchanges/<PR#>.misc.rst: infrastructure or miscellaneous change