Skip to content

Conversation

@braingram
Copy link
Collaborator

@braingram braingram commented Oct 13, 2025

This updates the from-schema building code to handle patternProperties to:

Regtests all pass: https://github.com/spacetelescope/RegressionTests/actions/runs/18477730458

Tasks

  • Update or add relevant roman_datamodels tests.
  • Update relevant docstrings and / or docs/ page.
  • Does this PR change any API used downstream? (If not, label with no-changelog-entry-needed.)
News fragment change types:
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@braingram braingram changed the title esupport patternProperties required in schema support patternProperties required in schema Oct 13, 2025
@codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

❌ Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.84%. Comparing base (087a60d) to head (3496b1f).
⚠️ Report is 222 commits behind head on main.

Files with missing lines Patch % Lines
src/roman_datamodels/_stnode/_schema.py 90.90% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #591      +/-   ##
==========================================
- Coverage   97.56%   94.84%   -2.72%     
==========================================
  Files          30       27       -3     
  Lines        2788     2677     -111     
==========================================
- Hits         2720     2539     -181     
- Misses         68      138      +70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@braingram braingram marked this pull request as ready for review October 13, 2025 21:33
@braingram braingram requested a review from a team as a code owner October 13, 2025 21:33
@braingram braingram force-pushed the pattern_properties branch 2 times, most recently from 0f81f79 to 5ca6e7d Compare October 28, 2025 15:37
@braingram braingram requested a review from PaulHuwe December 30, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant