Skip to content

Conversation

@WilliamJamieson
Copy link
Collaborator

In this comment: #615 (comment) it was pointed out that the group dq flags are in fact unsigned 8 bit integers not unsigned 32 bit integers. This is confirmed by the ramp schema: https://github.com/spacetelescope/rad/blob/c063796494d7526840d9e3ca37cccff3fcc9ad43/latest/ramp.yaml#L47

This PR updates the groupdq flags to be uint8 instead of uint32 and adds tests to make sure the dq flags meet the type expectations of the schemas.

Tasks

  • Update or add relevant roman_datamodels tests.
  • Update relevant docstrings and / or docs/ page.
  • Does this PR change any API used downstream? (If not, label with no-changelog-entry-needed.)
News fragment change types:
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.95%. Comparing base (087a60d) to head (f66bc5a).
⚠️ Report is 221 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #616      +/-   ##
==========================================
- Coverage   97.56%   94.95%   -2.61%     
==========================================
  Files          30       27       -3     
  Lines        2788     2695      -93     
==========================================
- Hits         2720     2559     -161     
- Misses         68      136      +68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@WilliamJamieson WilliamJamieson marked this pull request as ready for review December 19, 2025 20:13
@WilliamJamieson WilliamJamieson requested a review from a team as a code owner December 19, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant