Implement logger for roman_photoz#15
Merged
mairanteodoro merged 4 commits intospacetelescope:mainfrom May 1, 2025
Merged
Conversation
schlafly
approved these changes
Apr 22, 2025
Collaborator
schlafly
left a comment
schlafly
left a comment
There was a problem hiding this comment.
Thanks Mairan, this looks reasonable to me. If this makes a log file every time we run, though, I think we should reconsider; I don't think we want to make an additional product to archive, etc.. If the log file is optional, that makes more sense, or if we can put the logs in the ordinary output file rather than writing it out, that would also make sense.
mairanteodoro
added a commit
to mairanteodoro/roman_photoz
that referenced
this pull request
May 2, 2025
* Implement logger for roman_photoz. * Prevent logger from writing to file. * Resolve conflicts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the implementation of a logger module, which added a centralized logging configuration in
__init__.pywith:setup_logging()function that configures the logger;The logging implementation allows for consistent logging throughout the module with proper log levels (info, warning, error, exception). The log messages will be written to the console, making it easier to track the execution of the code and diagnose issues.