Merged
Conversation
pllim
reviewed
Apr 25, 2025
Collaborator
Author
|
|
Co-authored-by: Eddie Schlafly <eschlafly@gmail.com>
Co-authored-by: Eddie Schlafly <eschlafly@gmail.com>
…e when necessary. (spacetelescope#14) * Implement check for previously created model file. * Style check fixes.
* Implement logger for roman_photoz. * Prevent logger from writing to file. * Resolve conflicts.
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4 to 5. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-python dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
schlafly
approved these changes
May 5, 2025
Collaborator
schlafly
left a comment
schlafly
left a comment
There was a problem hiding this comment.
Thanks, this looks fine.
I'll note that to my sensibilities a lot of the tests relying on patching aren't testing very much. "assert_called_once_with" asserts just don't seem to me to be very useful tests; I'd much rather see minimal data included and processed correctly or something. And as we have discussed, let's try to get a real test in with some minimal data where some real catalog gets processed and passed to lephare and fit and some photo-zs are derived from it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds improves code-testing coverage.