AL-1042: Use roman-specific tweakwcs corrector

[mcara]

Resolves AL-1042

This PR switches correctors used in tweakreg from a jwst corrector to a dedicated roman-specific corrector. This PR depends on spacetelescope/tweakwcs#243 and spacetelescope/stcal#529 being merged and teakwcs version 0.9.0 be released. Unit tests will not pass unless we modify pyproject.toml to use those branches of stcal and tweakwcs.

Tasks

• request a review from someone specific, to avoid making the maintainers review every PR
• add a build milestone, i.e. 24Q4_B15 (use the latest build if not sure)
• Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
  • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
    • if your change breaks existing functionality, also add a changes/<PR#>.breaking.rst news fragment
  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • start a regression test and include a link to the running job (click here for instructions)
    • Do truth files need to be updated ("okified")?
      • after the reviewer has approved these changes, run okify_regtests to update the truth files
• if a JIRA ticket exists, make sure it is resolved properly

[mcara]

Regression test: https://github.com/spacetelescope/RegressionTests/actions/runs/22790148636

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.99%. Comparing base (2640904) to head (c66b625).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2219   +/-   ##
=======================================
  Coverage   80.99%   80.99%           
=======================================
  Files         159      159           
  Lines        9502     9503    +1     
=======================================
+ Hits         7696     7697    +1     
  Misses       1806     1806           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[mcara]

Although regression tests fail, it is actually just one unit test that is failing and, based on the line numbers in the traceback, it looks like unit tests (when run as part of the entire regression test) do not use install overrides and so they do not use required package versions by tweakwcs and stcal.

[mcara]

Last commit (only temporary, to illustrate the last point) sets dependency to spacetelescope/stcal#529 and the regression tests with this commit are: https://github.com/spacetelescope/RegressionTests/actions/runs/22793185624

[mcara]

Tests are going to fail until the stcal and tweakreg PRs are merged. In a similar PR for romancal, once I modified pyproject.toml thests passes (they were failing with the same error): #2219

[mcara]

If you want, I can make a temporary commit to make them pass (it will need to be dropped before merging)

[schlafly]

I'm okay with either a temporary commit or a link to passing regression tests. The approach you're taking here looks reasonable to me and I'm happy to move forward with it, pending your deciding which of the various options is the best. Thanks!

[mairanteodoro]

Looks good to me! Thanks, Mihai!

I can approve once all the tests are passing.

[PaulHuwe]

LGTM - Thanks!

[schlafly]

One minor comment inline. In general I'm happy to approve this conditionally upon the dependencies getting merged.

If I understood correctly, the stcal release (that will pull in the tweakwcs release) is still compatible with the old code, so that release can happen without needing to bump stcal's major version number, and then this PR can go in?

[mcara]

One minor comment inline. In general I'm happy to approve this conditionally upon the dependencies getting merged.

If I understood correctly, the stcal release (that will pull in the tweakwcs release) is still compatible with the old code, so that release can happen without needing to bump stcal's major version number, and then this PR can go in?

Yes, stcal PR can be merged independently and it should be backwards compatible as these tests show: spacetelescope/stcal#529 (comment)

[mairanteodoro]

I see that all the other PRs connected with this one have been merged. Thanks, @mcara!

[mcara]

Do not merge this PR until there is a new release of stcal and pyproject.toml is updated accordingly.

[mcara]

JWST PR does not need stcal release or tweakwcs release. This PR needs stcal.

[schlafly]

Since the stcal PR is in, normally we were point pyproject.toml to point to stcal github main now, and then this could be merged?

[mcara]

Since the stcal PR is in, normally we were point pyproject.toml to point to stcal github main now, and then this could be merged?

Oh, if you are OK to pointing to stcal@main that should work.

[mcara]

ready to merge

[mcara]

Started a new run of regression tests: https://github.com/spacetelescope/RegressionTests/actions/runs/26597890960

[mcara]

Don't know what happened with CI but regression tests pass.

[mcara]

Oh, I see, it's spacetelescope/crds#1207 that prevents CI from starting. Anyway, regression tests pass so it should be OK to merge this.

[schlafly]

Thanks!