RCAL-1380: Populate SFD-estimated extinction in catalogs.#2313
Conversation
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…cified and allow usage of RSDP-specific authentication (spacetelescope#2273) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…ope#2305) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2313 +/- ##
==========================================
+ Coverage 80.60% 80.70% +0.09%
==========================================
Files 155 155
Lines 9409 9462 +53
==========================================
+ Hits 7584 7636 +52
- Misses 1825 1826 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
schlafly
left a comment
There was a problem hiding this comment.
Looks good to me. One minor comment inline. Thanks Mairan!
|
The oldestdeps python 3.11 tests were failing with NoneType in various source catalog steps. We probably need a rad version requirement to do this; we're saying that's okay here since it should pass in the regtests with the pyproject / roman_datamodels pointing to the right rad version. |
I drafted spacetelescope/roman_datamodels#676 to see what making a monorepo of |
Co-authored-by: Eddie Schlafly <eschlafly@gmail.com>
schlafly
left a comment
There was a problem hiding this comment.
Thanks, approved. I'll let you back out the pyproject toml changes and merge when the corresponding rad PR is in. We'll also need to okify the differences; I'll let you handle that when you merge?
Sounds good. |
This reverts commit bc63338.
The unit tests are failing with a is attempting to get the "description" where definition is None. Merging spacetelescope/rad#870 won't fix this as:
We will need:
@mairanteodoro would you update the rdm requirement in this PR? I'll open a rdm PR setting the rad requirement to main. |
Yep, I can do that. I assumed that we would have a released version soon, so I didn't think of changing the requirements. |
…cope#2313) Co-authored-by: Brett Graham <brettgraham@gmail.com> Co-authored-by: Tyler Desjardins <tddesjar@gmail.com> Co-authored-by: Eddie Schlafly <eschlafly@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Larry Bradley <larry.bradley@gmail.com> Co-authored-by: Jonathan Eisenhamer <eisenhamer@stsci.edu>
…cope#2313) Co-authored-by: Brett Graham <brettgraham@gmail.com> Co-authored-by: Tyler Desjardins <tddesjar@gmail.com> Co-authored-by: Eddie Schlafly <eschlafly@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Larry Bradley <larry.bradley@gmail.com> Co-authored-by: Jonathan Eisenhamer <eisenhamer@stsci.edu>
Resolves RCAL-1380
This PR adds support for populating a new
dust_ebvextinction column in Roman source and multiband catalogs using SFD dust maps resolved through CRDS. It updates the catalog schema and source-catalog generation logic, adds tests and regression checks for the new field.Note
This adjusts CI/tox setup to use temporary git-based dependency installs needed for the change.
We need to revert it before merging this PR.Done (unit tests will fail until the RAD PR is merged).Regression tests
Tasks
24Q4_B15(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)changes/<PR#>.breaking.rstnews fragmentdocs/pageokify_regteststo update the truth files