RCAL-1392 Refactor public vs private interface#2314
Open
stscieisenhamer wants to merge 12 commits into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2314 +/- ##
==========================================
+ Coverage 80.60% 80.71% +0.10%
==========================================
Files 155 159 +4
Lines 9409 9436 +27
==========================================
+ Hits 7584 7616 +32
+ Misses 1825 1820 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f577377 to
d957dd8
Compare
Open
Collaborator
Author
41ffaa2 to
3f5eeb5
Compare
ec9213e to
854308e
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
854308e to
c4b3c64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves RCAL-1392
This PR clarifies the distinction between the intended public API and private API. Significant change is placing most of the utility code into private modules.
Tasks
24Q4_B15(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)changes/<PR#>.breaking.rstnews fragmentdocs/pageokify_regteststo update the truth files