Conversation
update readthedocs config on main, actually on main
More RTD config debugging
More RTD debugging, continued
more readthedocs config debugging
Merging develop to main for V2.0.0 release
HOTFIX 2.0.1
Updating main to latest develop version
# Conflicts: # .gitignore
mperrin
left a comment
mperrin
left a comment
There was a problem hiding this comment.
Couple questions on this, after a Quick Look
| @@ -1 +1,2 @@ | |||
| recursive-include spaceKLIP/resources * | |||
There was a problem hiding this comment.
Just to check, is this intentional to remove the spaceKLIP/resources subdirectory from the manifest? That seems wrong to me, because then all the reference files within that directory will not be included in the PyPI installation version, I think.
Likewise I'm not sure why the logo or readme would need to be included in this?
| TWINE_USERNAME: __token__ | ||
| TWINE_PASSWORD: ${{ secrets.PYPI_TOKEN }} | ||
| run: | | ||
| python -m twine upload dist/* No newline at end of file |
There was a problem hiding this comment.
For this file, consider instead using the workflow from open astronomy. See https://github-actions-workflows.openastronomy.org/en/latest/publish.html
That's what we use in webbpsf, and various other ST packages. See https://github.com/spacetelescope/webbpsf/blob/develop/.github/workflows/build.yml
I think it's a nice standardization to let someone else take care of the build script, and just reuse that across projects...
Update to develop
2 participants
A few changes to allow the package to be uploaded to PyPI. An example version (with incorrect version number) can be found here:
https://test.pypi.org/project/spaceKLIP/
Tested and able to install spaceKLIP through this link (note that dependencies have to be installed from regular PyPI).
Also added an integration for Github workflows for releases, but this isn't currently enabled as the github secret isn't set.