JP-3737: Handle micrometeorite flashes (v2)#349
Draft
drlaw1558 wants to merge 1 commit intospacetelescope:mainfrom
Draft
JP-3737: Handle micrometeorite flashes (v2)#349drlaw1558 wants to merge 1 commit intospacetelescope:mainfrom
drlaw1558 wants to merge 1 commit intospacetelescope:mainfrom
Conversation
This was referenced Mar 7, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #349 +/- ##
==========================================
- Coverage 85.96% 85.78% -0.18%
==========================================
Files 61 61
Lines 10333 10358 +25
==========================================
+ Hits 8883 8886 +3
- Misses 1450 1472 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses JP-3737 by adding an additional check in the jump step to look for micrometeorite flashes, which manifest as bursts of jumps across a large fraction of the detector. This replaces prior PR #308, updating it to work with the refactored jump step. Corresponding jwst PR is spacetelescope/jwst#9253
Kept in draft form for now pending potential future modifications.