Skip to content

[jump] add type hints#411

Draft
zacharyburnett wants to merge 1 commit intospacetelescope:mainfrom
zacharyburnett:jump/type_hints
Draft

[jump] add type hints#411
zacharyburnett wants to merge 1 commit intospacetelescope:mainfrom
zacharyburnett:jump/type_hints

Conversation

@zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Sep 24, 2025

add type hints for mypy validation

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run regression tests with this branch installed ("git+https://github.com/<fork>/stcal@<branch>")
news fragment change types...
  • changes/<PR#>.apichange.rst: change to public API
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change

apply type checker fixes

fix calc_num_slices type hints
@zacharyburnett zacharyburnett self-assigned this Sep 24, 2025
@github-actions github-actions bot added the jump label Sep 24, 2025
@codecov
Copy link

codecov bot commented Sep 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.26%. Comparing base (34d7704) to head (0a22283).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #411      +/-   ##
==========================================
- Coverage   89.50%   89.26%   -0.25%     
==========================================
  Files          66       66              
  Lines       10209    10213       +4     
==========================================
- Hits         9138     9117      -21     
- Misses       1071     1096      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant