Skip to content

Remove DataModel.open_asdf (deprecated since 3.0.1)#596

Merged
tapastro merged 3 commits into
spacetelescope:mainfrom
emolter:remove-open-asdf
Oct 8, 2025
Merged

Remove DataModel.open_asdf (deprecated since 3.0.1)#596
tapastro merged 3 commits into
spacetelescope:mainfrom
emolter:remove-open-asdf

Conversation

@emolter
Copy link
Copy Markdown
Contributor

@emolter emolter commented Oct 3, 2025

Closes #299

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run jwst regression tests with this branch installed ("git+https://github.com/<fork>/stdatamodels@<branch>")
news fragment change types...
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@emolter
Copy link
Copy Markdown
Contributor Author

emolter commented Oct 3, 2025

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.12%. Comparing base (a2c393a) to head (1a75983).
⚠️ Report is 101 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #596      +/-   ##
==========================================
+ Coverage   90.08%   90.12%   +0.03%     
==========================================
  Files         111      111              
  Lines        5327     5317      -10     
==========================================
- Hits         4799     4792       -7     
+ Misses        528      525       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@emolter emolter marked this pull request as ready for review October 3, 2025 20:05
@emolter emolter requested a review from a team as a code owner October 3, 2025 20:05
@emolter emolter requested a review from braingram October 3, 2025 21:02
@tapastro tapastro enabled auto-merge October 8, 2025 17:18
@tapastro tapastro merged commit 9da24e8 into spacetelescope:main Oct 8, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Datamodel.open_asdf

2 participants