Skip to content

Remove noqas in transform models#597

Merged
tapastro merged 3 commits into
spacetelescope:mainfrom
emolter:remove-noqas
Oct 8, 2025
Merged

Remove noqas in transform models#597
tapastro merged 3 commits into
spacetelescope:mainfrom
emolter:remove-noqas

Conversation

@emolter
Copy link
Copy Markdown
Contributor

@emolter emolter commented Oct 3, 2025

Closes #390

This PR makes a few small changes to the Snell and GrismObject models that allow for the removal of some style rule ignores.

With this PR, all the comments in #383 that prompted the creation of #390 and sub-tickets are addressed, so we should be ok to close out that ticket.

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run jwst regression tests with this branch installed ("git+https://github.com/<fork>/stdatamodels@<branch>")
news fragment change types...
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.13%. Comparing base (1a75983) to head (2f233c2).
⚠️ Report is 97 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #597   +/-   ##
=======================================
  Coverage   90.12%   90.13%           
=======================================
  Files         111      111           
  Lines        5317     5321    +4     
=======================================
+ Hits         4792     4796    +4     
  Misses        525      525           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@emolter emolter changed the title Remove noqas Remove noqas in transform models Oct 3, 2025
@emolter emolter added the no-changelog-entry-needed Trivial change that doesn't need an entry in the change log label Oct 3, 2025
@emolter
Copy link
Copy Markdown
Contributor Author

emolter commented Oct 3, 2025

@emolter emolter marked this pull request as ready for review October 3, 2025 21:02
@emolter emolter requested a review from a team as a code owner October 3, 2025 21:02
@emolter emolter requested a review from braingram October 3, 2025 21:02
@tapastro tapastro enabled auto-merge October 8, 2025 19:12
@tapastro tapastro merged commit b4fda16 into spacetelescope:main Oct 8, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog-entry-needed Trivial change that doesn't need an entry in the change log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Increase test coverage to remove some added noqas

2 participants