ForwardDispersion Model for MIRI and make MIRI and NIRISS use the same method#600
Conversation
fde71fd to
387d1d2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #600 +/- ##
==========================================
- Coverage 90.13% 90.10% -0.03%
==========================================
Files 111 111
Lines 5321 5306 -15
==========================================
- Hits 4796 4781 -15
Misses 525 525 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I am fine with the name WFSSForwardDispersion. I think the fact that MIRI and NIRISS but not NIRCam will share code means a bit of messiness is unavoidable in the naming. In my opinion it's not worth the trouble to change the names of anything non-MIRI-related, since those are already in active use. |
|
Also since looking at the PR the only things that need to be changed are "private", these name changes should be non-controversial |
4bce0f7 to
8e2deba
Compare
|
@jemorrison it looks like the docs build is failing because you need to add any new classes to the ignores list here: stdatamodels/docs/source/conf.py Line 63 in b4fda16 Please do also add a changelog entry saying something about the forward dispersion model bugfix |
|
@emolter When you say do not remove old ones from conf.py - do you also mean do not remove _NIRISSForwardGrismDispersion ? |
|
No I didn't say don't remove old ones, please do remove any names that are now unused |
|
Sorry I read you comment before my coffee this morning. Got it now |
emolter
left a comment
There was a problem hiding this comment.
Other than one suggestion about the changelog this looks good to me.
|
regression test passed: https://github.com/spacetelescope/RegressionTests/actions/runs/18507985858 |
Helps to resolve Resolves JP-3942
Closes #
This PR addresses updates the Forward model used for MIRWFSS. The Forward model for both NIRISS and MIRI are the same. The private module's name was changed to WFSSForwardGrismDistortion
Tasks
docs/pageno-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types)jwstregression tests with this branch installed ("git+https://github.com/<fork>/stdatamodels@<branch>")Regression tests passed
https://github.com/spacetelescope/RegressionTests/actions/runs/18507985858
news fragment change types...
changes/<PR#>.feature.rst: new featurechanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.doc.rst: documentation changechanges/<PR#>.removal.rst: deprecation or removal of public APIchanges/<PR#>.misc.rst: infrastructure or miscellaneous change