Skip to content

JP-4242: Add trace_model to slit model #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
melanieclarke wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

JP-4242: Add trace_model to slit model #697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/697.feature.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add a trace model image to slit datamodels.
1 change: 1 addition & 0 deletions src/stdatamodels/jwst/datamodels/schemas/ifuimage.schema.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ allOf:
title: Trace model
fits_hdu: TRACEMODEL
datatype: float32
ndim: 2
- $ref: variance.schema
- type: object
properties:
Expand Down
5 changes: 5 additions & 0 deletions src/stdatamodels/jwst/datamodels/schemas/slitdata.schema.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,11 @@ allOf:
fits_hdu: CON
default: 0
datatype: int32
trace_model:
title: Trace model
fits_hdu: TRACEMODEL
datatype: float32
ndim: 2
- $ref: variance.schema
- $ref: flatcorr.schema
- $ref: pathlosscorr.schema
Expand Down
4 changes: 4 additions & 0 deletions src/stdatamodels/jwst/datamodels/slit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ class SlitDataModel(JwstDataModel):
photom array for uniform source
area : numpy float32 array
Pixel area map array
trace_model : numpy float32 array
Trace model array
"""

schema_url = "http://stsci.edu/schemas/jwst_datamodel/slitdata.schema"
Expand Down Expand Up @@ -91,6 +93,8 @@ class SlitModel(JwstDataModel):
Photom array for uniform source
area : numpy float32 array
Pixel area map array
trace_model : numpy float32 array
Trace model array
int_times : numpy table
Table of times for each integration
"""
Expand Down
9 changes: 8 additions & 1 deletion tests/jwst/datamodels/test_multislit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,12 +65,19 @@ def test_multislit():
slit.data = rng.random((5, 5))
slit.dm = rng.random((5, 5))
slit.err = rng.random((5, 5))
for attr in ["wavelength", "pathloss_point", "pathloss_uniform", "barshadow"]:
for attr in [
"wavelength",
"pathloss_point",
"pathloss_uniform",
"barshadow",
"trace_model",
]:
setattr(dm.slits[-1], attr, dm.slits[-1].get_default(attr))
assert slit.wavelength.shape == (0, 0)
assert slit.pathloss_point.shape == (0, 0)
assert slit.pathloss_uniform.shape == (0, 0)
assert slit.barshadow.shape == (0, 0)
assert slit.trace_model.shape == (0, 0)


def test_multislit_from_image():
Expand Down
Loading