Fix PR template checklist#717
Conversation
pllim
added
the
no-changelog-entry-needed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #717 +/- ##
=======================================
Coverage 90.37% 90.37%
=======================================
Files 99 99
Lines 4582 4582
=======================================
Hits 4141 4141
Misses 441 441 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
CI failures are not related. |
| - [ ] Does this PR change any API used downstream? (if not, label with `no-changelog-entry-needed`) | ||
| - [ ] write news fragment(s) in `changes/`: `echo "changed something" > changes/<PR#>.<changetype>.rst` (see below for change types) | ||
| - [ ] [run `jwst` regression tests](https://github.com/spacetelescope/RegressionTests/actions/workflows/jwst.yml) with this branch installed (`"git+https://github.com/<fork>/stdatamodels@<branch>"`) | ||
| - [ ] [run `jwst` regression tests](https://github.com/spacetelescope/RegressionTests/actions/workflows/jwst.yml) with this branch installed (`stdatamodels@git+https://github.com/<fork>/stdatamodels@<branch>`) |
There was a problem hiding this comment.
I typically use the other format. Any reason to prefer this one?
There was a problem hiding this comment.
Because the workflow used to explicitly recommend this version. I see that those examples are now gone. 🤷♀️
There was a problem hiding this comment.
Since both work. Can we close this PR?
There was a problem hiding this comment.
The indent is still wrong though.
There was a problem hiding this comment.
I don't believe so. jwst is downstream here so if there are no downstream changes there's no need to run jwst regtests.
There was a problem hiding this comment.
hmm ok then, thx for clarification
2 participants
This PR addresses PR template. No need for RT.
Tasks
docs/pageno-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types)jwstregression tests with this branch installed ("git+https://github.com/<fork>/stdatamodels@<branch>")news fragment change types...
changes/<PR#>.feature.rst: new featurechanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.doc.rst: documentation changechanges/<PR#>.removal.rst: deprecation or removal of public APIchanges/<PR#>.misc.rst: infrastructure or miscellaneous change